Skip to content

ref(cells): clean up temporary aliases needed for getsentry#111599

Merged
lynnagara merged 7 commits intomasterfrom
cleanup-getsentry-aliases
Mar 30, 2026
Merged

ref(cells): clean up temporary aliases needed for getsentry#111599
lynnagara merged 7 commits intomasterfrom
cleanup-getsentry-aliases

Conversation

@lynnagara
Copy link
Copy Markdown
Member

No description provided.

@lynnagara lynnagara requested a review from a team March 26, 2026 01:06
@lynnagara lynnagara requested review from a team as code owners March 26, 2026 01:06
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 26, 2026
Comment thread src/sentry/testutils/silo.py Outdated
Copy link
Copy Markdown
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build failures look relevant.

@lynnagara
Copy link
Copy Markdown
Member Author

needs #111602 first

Comment thread src/sentry/testutils/silo.py
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment thread tests/sentry/models/test_projectkeymapping.py Outdated
Copy link
Copy Markdown
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than the typing issues

@github-actions
Copy link
Copy Markdown
Contributor

Backend Test Failures

Failures on e71cd6c in this run:

tests/sentry/management/commands/test_generate_controlsilo_urls.py::TestGenerateControlsiloUrls::test_no_missing_urlslog
tests/sentry/management/commands/test_generate_controlsilo_urls.py:70: in test_no_missing_urls
    assert line in current_state, msg
E   AssertionError: 
E                 New control silo URL patterns detected!
E     
E                 The pattern:   new RegExp('^api/0/organizations/[^/]+/pipeline/[^/]+/$'),
E     
E                 Does not exist in the current pattern inventory. You should regenerate
E                 the pattern inventory with:
E     
E                 cd ../getsentry
E                 getsentry django generate_controlsilo_urls --format=js --output=../sentry/static/app/data/controlsiloUrlPatterns.ts
E     
E                 This command needs to be run in a getsentry environment
E                 in order to not lose patterns that are important for sentry.io
E                 
E   assert "  new RegExp('^api/0/organizations/[^/]+/pipeline/[^/]+/$')," in "// This is generated code.\n// To update it run `getsentry django generate_controlsilo_urls --format=js --output=/pat...gExp('^extensions/discord/link-identity/[^/]+/$'),\n  new RegExp('^extensions/discord/unlink-identity/[^/]+/$'),\n];\n"

@lynnagara
Copy link
Copy Markdown
Member Author

needs a few more cleanups from https://github.com/getsentry/getsentry/pull/19695 too

@lynnagara
Copy link
Copy Markdown
Member Author

lynnagara commented Mar 30, 2026

@lynnagara lynnagara merged commit abd3470 into master Mar 30, 2026
107 checks passed
@lynnagara lynnagara deleted the cleanup-getsentry-aliases branch March 30, 2026 21:15
@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants